Work around some race conditions in MCP prototype #7397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-adam
approved these changes
Feb 7, 2026
| // Spring AI GoogleGenAiChatModel bug: empty candidates cause NoSuchElementException | ||
| // https://github.com/spring-projects/spring-ai/issues/4556 | ||
| LOG.warn("Empty response from chat model (likely a filtered or empty candidate)", x); | ||
| return List.of(new MessageResponse("text/plain", "The model returned an empty response. Please try rephrasing your question.", HtmlString.of("The model returned an empty response. Please try rephrasing your question."))); |
Contributor
There was a problem hiding this comment.
I ran into this early today. In my case, I resubmitted the exact same question and got a good response. So maybe advice should be, "Please try resubmitting your question." Then again, I didn't look under the covers to see what was happening.
Contributor
Author
There was a problem hiding this comment.
Rephrased. I have a separate local hack that I didn't commit that tries to filter out these empty messages. I'm not sure it's working as intended so holding off on pushing that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
We've got some rough spots in terms of synchronization and error handling. We can give our brave alpha testers slightly better messages.
Changes